Fix detection of annotated git tags #74
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relying only on local resources results in more reliable test results and enables development without reliable internet access. Signed-off-by: Scott K Logan <logans@cottsay.net>
This commit extends vcs2l's tag detection scheme to support annotated tags, building on the existing support for lightweight tags. The new detection logic adds awareness of some git plumbing details regarding how the tag's message is stored in relation to the SHA it references. I updated the test to use an annotated tag for one of the tags in the list to exercise this feature. Signed-off-by: Scott K Logan <logans@cottsay.net>
nuclearsandwich
previously approved these changes
Oct 3, 2025
cottsay
force-pushed
the
cottsay/offline-tests
branch
from
b1aeee0 to
79c194d
Compare
leander-dsouza
dismissed
nuclearsandwich’s stale review
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
This commit extends vcs2l's tag detection scheme to support annotated tags, building on the existing support for lightweight tags. The new detection logic adds awareness of some git plumbing details regarding how the tag's message is stored in relation to the SHA it references.
I updated the test to use an annotated tag for one of the tags in the list to exercise this feature.
Specifically, this affects the
vcs exportcommand when--exact-with-tagsis used.Description of how this change was tested
pre-commit run --allpython3 -m pytest -s -v testImportant
This is in "draft" against the
cottsay/offline-testsbranch until that PR is merged. I'll then rebase this againstmainfor final review.